[ 
https://issues.apache.org/jira/browse/TAJO-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679439#comment-14679439
 ] 

ASF GitHub Bot commented on TAJO-1743:
--------------------------------------

Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/678#discussion_r36596307
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java
 ---
    @@ -56,14 +57,19 @@
       private KeyProjector keyProjector;
     
       public RangeShuffleFileWriteExec(final TaskAttemptContext context,
    -                                   final PhysicalExec child, final Schema 
inSchema, final Schema outSchema,
    -                                   final SortSpec[] sortSpecs) throws 
IOException {
    -    super(context, inSchema, outSchema, child);
    +                                   final ShuffleFileWriteNode plan,
    --- End diff --
    
    Could you explain why you remove output schema from parameters of the 
constructor?


> Improve calculation of intermediate table statistics
> ----------------------------------------------------
>
>                 Key: TAJO-1743
>                 URL: https://issues.apache.org/jira/browse/TAJO-1743
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Data Shuffle, Physical Operator, Storage
>    Affects Versions: 0.8.0, 0.9.0, 0.10.0, 0.10.1
>            Reporter: Jinho Kim
>            Assignee: Jinho Kim
>             Fix For: 0.11.0
>
>
> Internal storage calculates the statistic(min, max) for intermediate data 
> shuffling. but the statistics requires only to the range shuffle in the 
> current implementation. We should remove unnecessary computing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to