[ 
https://issues.apache.org/jira/browse/TAJO-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694613#comment-14694613
 ] 

ASF GitHub Bot commented on TAJO-1748:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/680#discussion_r36937521
  
    --- Diff: 
tajo-common/src/main/java/org/apache/tajo/exception/DuplicateFunctionException.java
 ---
    @@ -0,0 +1,34 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.exception;
    +
    +import org.apache.tajo.error.Errors;
    +import org.apache.tajo.rpc.protocolrecords.PrimitiveProtos.ReturnState;
    +
    +public class DuplicateFunctionException extends TajoException {
    +   private static final long serialVersionUID = 3224521585413794703L;
    +
    +  public DuplicateFunctionException(ReturnState state) {
    +    super(state);
    +  }
    +
    +   public DuplicateFunctionException(String signature) {
    --- End diff --
    
    fixed


> Refine client APIs to throw specific exceptions
> -----------------------------------------------
>
>                 Key: TAJO-1748
>                 URL: https://issues.apache.org/jira/browse/TAJO-1748
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Catalog, Java Client
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>
> This patch includes lots of API changes in terms of only exceptions. In 
> overall, this patch changes throwable exceptions for APIs and unit tests to 
> ensure that the APIs throws exact exceptions. 
> In sum, this patch includes the following changes:
> * Rename TajoExceptionInterface to DefaultTajoException.
> * Rename UnImplementedException to NotImplementedException.
> * Replace CatalogException by TajoException
> * Move almost TajoException/TajoRunException in tajo-core into tajo-common
> * Remove CatalogException and CatalogExceptionUtil
> * Add throwable exception to all APIs in TajoClient, QueryClient, 
> CatalogService, and CatalogAdminClient.
> * Refine all client implementations to throw received exception exactly.
> * Add negative unit tests for all APIs of them
> * Refine Client API v2 to handle exceptional cases like query failed, and 
> killed.
> * Add query fail and kill tests for Client v2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to