[ 
https://issues.apache.org/jira/browse/TAJO-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721885#comment-14721885
 ] 

ASF GitHub Bot commented on TAJO-1465:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/652#discussion_r38281312
  
    --- Diff: 
tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java
 ---
    @@ -152,11 +155,13 @@ public void init() throws IOException {
     
         orcReader = new OrcReader(orcDataSource, new OrcMetadataReader());
     
    +    TimeZone timezone = 
TimeZone.getTimeZone(meta.getOption(StorageConstants.TIMEZONE,
    +      TajoConstants.DEFAULT_SYSTEM_TIMEZONE));
    +
         // TODO: make OrcPredicate useful
    -    // TODO: TimeZone should be from conf
    -    // TODO: it might be splittable
    +    // presto-orc uses joda timezone, so it needs to be converted.
    --- End diff --
    
    Could you explain what is Joda timezone? It seems to be just a java 
timezone.


> Add ORCFileAppender to write into ORCFile table
> -----------------------------------------------
>
>                 Key: TAJO-1465
>                 URL: https://issues.apache.org/jira/browse/TAJO-1465
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Storage
>    Affects Versions: 0.10.0
>            Reporter: Dongjoon Hyun
>            Assignee: Jongyoung Park
>              Labels: orc
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to