[ 
https://issues.apache.org/jira/browse/TAJO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736820#comment-14736820
 ] 

ASF GitHub Bot commented on TAJO-1340:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/671#discussion_r39039858
  
    --- Diff: 
tajo-client/src/main/java/org/apache/tajo/jdbc/FetchResultSet.java ---
    @@ -25,11 +25,13 @@
     
     import java.io.IOException;
     import java.sql.SQLException;
    +import java.util.concurrent.Future;
     
     public class FetchResultSet extends TajoResultSetBase {
       protected QueryClient tajoClient;
       private int fetchRowNum;
       private TajoMemoryResultSet currentResultSet;
    +  private Future<TajoMemoryResultSet> nextResultSet;
    --- End diff --
    
    It looks that ```nextResultSet``` should also be closed when 
FetchResultSet.close() is called.


> Change the default output file format.
> --------------------------------------
>
>                 Key: TAJO-1340
>                 URL: https://issues.apache.org/jira/browse/TAJO-1340
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Java Client, JDBC Driver, Offheap, Storage
>            Reporter: Hyunsik Choi
>            Assignee: Jinho Kim
>             Fix For: 0.11.0, 0.12.0
>
>         Attachments: TAJO-1340.patch, TAJO-1340_2.patch
>
>
> Currently, the default output file is CSV. Due to its nature, CSV has mainly 
> three problems:
>  * Its line or field delimiter can be duplicated to some character included 
> in the result data.
>  * Plan text file is likely to be larger than other file formats.
>  * Its read and write performance is slow.
> We need to change the default output file format into other file formats. We 
> also need to investigate which file format is the best for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to