[ 
https://issues.apache.org/jira/browse/TAJO-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882718#comment-13882718
 ] 

Tajo QA commented on TAJO-372:
------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12625342/TAJO-372.patch
  against master revision eb563ad.

    {color:green}+1 @author.{color}  The patch does not contain any @author 
tags.

    {color:green}+1 tests included.{color}  The patch appears to include 2 new 
or modified test files.

    {color:green}+1 javac.{color}  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the 
total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 263 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests.{color}  The patch failed these unit tests in 
tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-common 
tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend tajo-rpc: 
                  org.apache.tajo.engine.function.TestBuiltinFunctions
                  org.apache.tajo.jdbc.TestTajoJdbc
                  org.apache.tajo.engine.query.TestNullValues
                  org.apache.tajo.engine.query.TestUnionQuery
                  org.apache.tajo.engine.query.TestGroupByQuery
                  org.apache.tajo.engine.query.TestSortQuery
                  org.apache.tajo.storage.TestRowFile
                  org.apache.tajo.benchmark.TestTPCH
                  org.apache.tajo.engine.query.TestJoinQuery
                  org.apache.tajo.engine.query.TestCaseByCases
                  org.apache.tajo.client.TestTajoClient
                  org.apache.tajo.engine.query.TestSelectQuery
                  org.apache.tajo.engine.query.TestInsertQuery
                  org.apache.tajo.engine.query.TestCreateTable
                  org.apache.tajo.engine.query.TestCTASQuery
                  org.apache.tajo.engine.query.TestTableSubQuery
                  org.apache.tajo.engine.query.TestTablePartitions

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/81//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-rpc.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/81//console

This message is automatically generated.

> When an exception except for network issues occurs, the operation should not 
> be repeated.
> -----------------------------------------------------------------------------------------
>
>                 Key: TAJO-372
>                 URL: https://issues.apache.org/jira/browse/TAJO-372
>             Project: Tajo
>          Issue Type: Bug
>          Components: client
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-372.patch
>
>
> Currently, TajoClient retries failed operations regardless of network issues. 
> It causes unnecessary retries as follows:
> {code}
> tajo> select l_shipmode, sum(case when o_orderpriority ='1-URGENT' or 
> o_orderpriority ='2-HIGH' then 1 else 0 end) as high_line_count, sum(case 
> when o_orderpriority <> '1-URGENT' and o_orderpriority <> '2-HIGH' then 1 
> else 0 end) as low_line_count from orders, lineitem where o_orderkey = 
> l_orderkey and (l_shipmode = 'MAIL' or l_shipmode = 'SHIP') and l_commitdate 
> < l_receiptdate and l_shipdate < l_commitdate and l_receiptdate >= 
> '1994-01-01' and l_receiptdate < '1995-01-01' group by l_shipmode order by 
> l_shipmode;
> Failed after attempts=3, exceptions:
> org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation 
> "orders" does not exist
> org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation 
> "orders" does not exist
> org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation 
> "orders" does not exist
> {code}
> When the problem is caused by other problems except for network issues, the 
> operations should be not retried.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to