----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17491/#review33139 -----------------------------------------------------------
Ship it! +1 The patch looks nice and includes all necessary unit tests. - Hyunsik Choi On Jan. 29, 2014, 6:45 p.m., Jinho Kim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17491/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 6:45 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-506 > https://issues.apache.org/jira/browse/TAJO-506 > > > Repository: tajo > > > Description > ------- > > Suppose a following table. > {noformat} > CREATE TABLE t1 (logtime DATE, user TEXT); > {noformat} > > When I run the following query, I met an error that DATE type cannot be > supported by RawFile. > {noformat} > select * from t1 order by logtime limit 10; > {noformat} > > The detailed error logs are as follows. > {noformat} > 2014-01-16 12:51:35,799 ERROR worker.Task (Task.java:run(378)) - > java.io.IOException: Cannot support data type: DATE > at > org.apache.tajo.storage.RawFile$RawFileAppender.addTuple(RawFile.java:485) > at > org.apache.tajo.engine.planner.physical.RangeShuffleFileWriteExec.next(RangeShuffleFileWriteExec.java:100) > at org.apache.tajo.worker.Task.run(Task.java:370) > at org.apache.tajo.worker.TaskRunner$1.run(TaskRunner.java:392) > at java.lang.Thread.run(Thread.java:701) > {noformat} > > > Diffs > ----- > > tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java > 3ff1fcacc84079427ba1992d55941f089b15284d > tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java > 0482857408d040fcd6841d8172266c957fdad17c > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java > 35d7743088172768de35f415115cd826de378103 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java > 8601cb55ac8c6db96f1b446f51f4ab2941ddee35 > > tajo-core/tajo-core-backend/src/test/resources/dataset/TestSortQuery/table1.tbl > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSortQuery/create_table_with_date_ddl.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSortQuery/testSortWithDate.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSortQuery/testSortWithDate.result > PRE-CREATION > tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java > db511dcf9bbe853925942c5272ca05f04f08bf43 > tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java > 9f320287c7ed27b23b85b14620ac4de524dd75fe > tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java > 9627a5d4e89841714e58d955897c4d4bb4f8f84a > tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java > 16b370c59aaa73fbc80a322176ab60dccd6f0eb1 > > Diff: https://reviews.apache.org/r/17491/diff/ > > > Testing > ------- > > mvn clean install > > > Thanks, > > Jinho Kim > >
