----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17692/#review33572 -----------------------------------------------------------
Ship it! +1 looks straigforward. Ship it! - Hyunsik Choi On Feb. 4, 2014, 2:27 p.m., Jinho Kim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17692/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 2:27 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-532 > https://issues.apache.org/jira/browse/TAJO-532 > > > Repository: tajo > > > Description > ------- > > Fix warnings in tajo-common. > > > Diffs > ----- > > dev-support/findbugs-exclude.xml e30545ade8b07630c1e5420f5ebbaea2463c25cf > tajo-common/src/main/java/org/apache/tajo/QueryId.java > af1ae566358ba3511b1bca61b2381aa810245d28 > tajo-common/src/main/java/org/apache/tajo/QueryIdFactory.java > b0affe9e5289b32cee8291a75d0b00c805e7972b > tajo-common/src/main/java/org/apache/tajo/TajoConstants.java > dc3b1f28149613be65a03aeac3c596b783093d98 > tajo-common/src/main/java/org/apache/tajo/common/type/IPv4.java > 1643674e58795cafd5424ed77f36b01fd41dca5c > tajo-common/src/main/java/org/apache/tajo/common/type/TimeRange.java > 4cd122cd954477275aa95e614aab975070f33931 > tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java > 38aa19156f0f64ac1ef99ec25238e33bd8111ed3 > tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java > c1fad569ff3728f78b1b9b36babd00ecf49cfa5f > tajo-common/src/main/java/org/apache/tajo/util/FileUtil.java > 194be559bd4b42c0e758a5892289c5b7a90c8344 > tajo-common/src/main/java/org/apache/tajo/util/NumberUtil.java > 1846d783dbfb57bbb75c94da8eb52f0e975db731 > tajo-common/src/main/java/org/apache/tajo/util/TUtil.java > df7c79f7447e1eded030aa02424332a20ef29641 > tajo-common/src/main/java/org/apache/tajo/util/TajoIdUtils.java > 521befc2c7398a597a9b1c7a790ffc116e450386 > tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java > 4a6b1817a01d8708bc405d7a087a1ff64ace6b53 > > Diff: https://reviews.apache.org/r/17692/diff/ > > > Testing > ------- > > mvn test findbugs:findbugs > > > Thanks, > > Jinho Kim > >
