----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17901/#review34186 -----------------------------------------------------------
Ship it! +1. This patch looks good to me. Please reflect the below comment before you commit. Thanks! tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java <https://reviews.apache.org/r/17901/#comment64199> There is an erratum. It seems to be fixed to 'supported'. - Jihoon Son On Feb. 11, 2014, 11:02 p.m., Jung JaeHwa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17901/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 11:02 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-592 > https://issues.apache.org/jira/browse/TAJO-592 > > > Repository: tajo > > > Description > ------- > > If hive table used default row format delimiter, hive doesn't return > field.delim. As the result, tajo can't scan hive tables which used default > row format delimiter. So, in this case, tajo must set field.delim to \001. > And current HCatalogStore just supports TextFile, it should supports RCFile. > At last, I found that HCatalogStore doesn't set compression and field.delim > when it created tables. So,we should implement these. > > > Diffs > ----- > > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java > 540ad0f > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java > 2c2400a > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java > 2a6e740 > > Diff: https://reviews.apache.org/r/17901/diff/ > > > Testing > ------- > > mvn clean install -Phcatalog-0.11.0 > mvn clean install -Phcatalog-0.12.0 > > > Thanks, > > Jung JaeHwa > >
