[
https://issues.apache.org/jira/browse/TAJO-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906745#comment-13906745
]
Hyunsik Choi edited comment on TAJO-614 at 2/20/14 8:47 AM:
------------------------------------------------------------
Created a review request against branch master in reviewboard:
https://reviews.apache.org/r/18305/
was (Author: hyunsik):
Created a review request against branch master in reviewboard
> Explaning a logical node should use ExplainLogicalPlanVisitor.
> --------------------------------------------------------------
>
> Key: TAJO-614
> URL: https://issues.apache.org/jira/browse/TAJO-614
> Project: Tajo
> Issue Type: Improvement
> Components: planner/optimizer
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Priority: Minor
> Fix For: 0.8-incubating
>
> Attachments: TAJO-614.patch
>
>
> Currently, many parts use LogicalNode::toString() for explaning plans. But,
> we already have ExplainLogicalPlanVisitor class to generate pretty print
> strings.
> This patch improves logical planning related parts to use
> ExplainLogicalPlanVisitor instead of toString().
> For this, I added PlannerUtil::buildExplainString for generating pretty print
> explain strings and simplified obsolete toString() methods of all
> LogicalNodes.
> It much improves the readability of explain string. I expect that it would be
> helpful for debugging and users' understanding of query plans.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)