[
https://issues.apache.org/jira/browse/TAJO-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906788#comment-13906788
]
Tajo QA commented on TAJO-614:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12630018/TAJO-614.patch
against master revision e63f4b0.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:green}+1 tests included.{color} The patch appears to include 2 new
or modified test files.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 178 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests.{color} The patch passed unit tests in
tajo-core/tajo-core-backend.
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/148//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/148//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/148//console
This message is automatically generated.
> Explaning a logical node should use ExplainLogicalPlanVisitor.
> --------------------------------------------------------------
>
> Key: TAJO-614
> URL: https://issues.apache.org/jira/browse/TAJO-614
> Project: Tajo
> Issue Type: Improvement
> Components: planner/optimizer
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Priority: Minor
> Fix For: 0.8-incubating
>
> Attachments: TAJO-614.patch
>
>
> Currently, many parts use LogicalNode::toString() for explaning plans. But,
> we already have ExplainLogicalPlanVisitor class to generate pretty print
> strings.
> This patch improves logical planning related parts to use
> ExplainLogicalPlanVisitor instead of toString().
> For this, I added PlannerUtil::buildExplainString for generating pretty print
> explain strings and simplified obsolete toString() methods of all
> LogicalNodes.
> It much improves the readability of explain string. I expect that it would be
> helpful for debugging and users' understanding of query plans.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
