----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18420/#review35267 -----------------------------------------------------------
Ship it! +1 for the patch. - Jinho Kim On Feb. 24, 2014, 12:07 p.m., Hyunsik Choi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18420/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 12:07 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-628 > https://issues.apache.org/jira/browse/TAJO-628 > > > Repository: tajo > > > Description > ------- > > Distinct aggregation requires three stages. But, the second stage can be > scheduled to one node due to wrong counting of grouping keys. > > This patch fixes this bug. In addition, this patch fixes some trivial bugs in > Task.java that I found during this debugging. > > > Diffs > ----- > > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java > 33e46fdfae72a38c27634c78c8d5c66afd6ebf7a > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java > 28386bb6764af7ee90cae066f3f7bf479264084d > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java > 066e11c11af0ebc2ce2b6d063da085d1ede0ae61 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/master/TestTajoResourceManager.java > 428bf4610bb45924c7dcc124638f3bf49e142020 > > Diff: https://reviews.apache.org/r/18420/diff/ > > > Testing > ------- > > mvn clean install. > > > Thanks, > > Hyunsik Choi > >
