[ 
https://issues.apache.org/jira/browse/TAJO-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914144#comment-13914144
 ] 

Hudson commented on TAJO-635:
-----------------------------

SUCCESS: Integrated in Tajo-master-build #90 (See 
[https://builds.apache.org/job/Tajo-master-build/90/])
TAJO-635: Improve tests of query semantic verification. (hyunsik: 
https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=03718031a113af7ccd7ddba2df7513f6b0b21c42)
* tajo-algebra/src/main/java/org/apache/tajo/algebra/FunctionExpr.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java
* CHANGES.txt
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/EvalNodeVisitor2.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/BetweenPredicateEval.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/BasicEvalNodeVisitor.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java


> Improve tests of query semantic verification
> --------------------------------------------
>
>                 Key: TAJO-635
>                 URL: https://issues.apache.org/jira/browse/TAJO-635
>             Project: Tajo
>          Issue Type: Bug
>    Affects Versions: 0.8-incubating, 1.0-incubating
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating, 1.0-incubating
>
>         Attachments: TAJO-635.patch
>
>
> See TAJO-633. This is caused by some missed visitor functions. When I 
> investigated TAJO-633, I found that there are more missed methods in 
> BasicEvalNodeVisitor and EvalNodeVisitor2. Also, I found that 
> ExprTestBase::testEval() does not use PreLogicalPlanVerifier, 
> LogicalOptimizer, and LogicalPlanVerifier. As a result, query semantic 
> verification has not been tested fully. This patch fixes all of them.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to