[ 
https://issues.apache.org/jira/browse/TAJO-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915511#comment-13915511
 ] 

Hudson commented on TAJO-602:
-----------------------------

FAILURE: Integrated in Tajo-master-build #93 (See 
[https://builds.apache.org/job/Tajo-master-build/93/])
TAJO-602: WorkerResourceManager should be broke down into 3 parts. (hyunsik) 
(hyunsik: 
https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=18aaa68e5ea8acb8edb7e2486d02758ab0478127)
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/rm/TajoWorkerContainer.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/rm/WorkerResourceManager.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryInfo.java
* tajo-core/tajo-core-backend/pom.xml
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/rm/TajoWorkerResourceManager.java
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/master/TestTajoResourceManager.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMaster.java
* 
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
* tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoWorker.java
* CHANGES.txt
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/rm/WorkerResource.java
* tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterService.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/rm/YarnTajoResourceManager.java
* tajo-core/tajo-core-backend/src/main/resources/webapps/admin/query.jsp
* tajo-core/tajo-core-backend/src/main/resources/webapps/admin/cluster.jsp
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryInProgress.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
* tajo-core/tajo-core-backend/src/main/proto/TajoMasterProtocol.proto
* 
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TajoTestingCluster.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryJobManager.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/metrics/WorkerResourceMetricsGaugeSet.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/rm/WorkerStatus.java
* tajo-core/tajo-core-backend/src/main/resources/webapps/admin/index.jsp
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
* 
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java


> WorkerResourceManager  should be broke down into 3 parts
> --------------------------------------------------------
>
>                 Key: TAJO-602
>                 URL: https://issues.apache.org/jira/browse/TAJO-602
>             Project: Tajo
>          Issue Type: Sub-task
>    Affects Versions: 1.0-incubating
>            Reporter: Min Zhou
>            Assignee: Hyunsik Choi
>             Fix For: 1.0-incubating
>
>         Attachments: TAJO-602.patch
>
>
> Before implementing a scheduler, I think we should do some refactoring at 
> first. There are 2 interfaces and 4 classes related to resource management, 
> they are WorkerResourceManager , YarnTajoResourceManager, 
> TajoWorkerResourceManager reside in TajoMaster, and ResourceAllocator, 
> YarnResourceAllocator, TajoResourceAllocator reside in QueryMasters.
> WorkerResourceManager actually plays 3 roles
> 1. Choose or start a QueryMaster for a query, and management it
> 2. allocate resource for query tasks / task runners (only for standalone mode)
> 3. Handle worker's heartbeat (only for standalone mode)
> If the scheduler is a decentralized one, like sparrow, we can allocate 
> resource for a QueryMaster as the same way for a TaskRunner.  So 1. and 2. 
> can use the same interface, but called by 2 different caller.    3. is 
> different from the others,  we can create another service, let's say 
> HeartbeatService to deal with worker's heartbeats. 
> Any suggestion?



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to