[
https://issues.apache.org/jira/browse/TAJO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13916034#comment-13916034
]
Tajo QA commented on TAJO-641:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12631786/TAJO-641.patch
against master revision f594542.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:red}-1 tests included.{color} The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests.{color} The patch passed unit tests in
tajo-catalog/tajo-catalog-common
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog tajo-client.
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/170//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/170//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-common.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/170//console
This message is automatically generated.
> NPE in HCatalogStore.addTable()
> -------------------------------
>
> Key: TAJO-641
> URL: https://issues.apache.org/jira/browse/TAJO-641
> Project: Tajo
> Issue Type: Bug
> Components: catalog
> Affects Versions: 0.8-incubating, 1.0-incubating
> Reporter: Jaehwa Jung
> Assignee: Jaehwa Jung
> Fix For: 0.8-incubating, 1.0-incubating
>
> Attachments: TAJO-641.patch
>
>
> Creating a table with _csvfile.delimiter_ results in NPE.
> * SQL
> create table table1 (id int, name text, score float, type text) using csv
> with ('csvfile.delimiter'='|') ;
> * TajoMaster log
> {code:xml}
> 2014-02-28 11:50:26,657 ERROR catalog.CatalogServer
> (CatalogServer.java:addTable(257)) -
> java.lang.NullPointerException
> at
> org.apache.tajo.catalog.store.HCatalogStore.addTable(HCatalogStore.java:335)
> at
> org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:255)
> at
> org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
> at
> org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
> at
> org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
> at
> org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
> at
> org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:320)
> at
> org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:283)
> at
> org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
> at
> org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
> at
> org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:162)
> at
> org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
> at
> org.apache.tajo.rpc.BlockingRpcServer$ServerHandler.messageReceived(BlockingRpcServer.java:103)
> at
> org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
> at
> org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
> at
> org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
> at
> org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296)
> at
> org.jboss.netty.handler.codec.oneone.OneToOneDecoder.handleUpstream(OneToOneDecoder.java:70)
> at
> org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
> at
> org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
> at
> org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296)
> at
> org.jboss.netty.handler.codec.frame.FrameDecoder.unfoldAndFireMessageReceived(FrameDecoder.java:462)
> at
> org.jboss.netty.handler.codec.frame.FrameDecoder.callDecode(FrameDecoder.java:443)
> at
> org.jboss.netty.handler.codec.frame.FrameDecoder.messageReceived(FrameDecoder.java:303)
> at
> org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
> at
> org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
> at
> org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:559)
> at
> org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:268)
> at
> org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:255)
> at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:88)
> at
> org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(AbstractNioWorker.java:109)
> at
> org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:312)
> at
> org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:90)
> at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
> at
> org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
> at
> org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
> at java.lang.Thread.run(Thread.java:680)
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
