-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18678/
-----------------------------------------------------------

(Updated March 3, 2014, 8:13 p.m.)


Review request for Tajo.


Bugs: TAJO-644
    https://issues.apache.org/jira/browse/TAJO-644


Repository: tajo


Description
-------

In SQL standards, non-ascii identifiers are supported by using double quotation 
as follows:
{code}
SELECT a, b, "?", d from table1
{code}

We should support quoted identifiers.


Diffs
-----

  CHANGES.txt 128ed99 
  
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4
 1ceaca8 
  
tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4
 db04d4b 
  
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
 a7b0a9e 
  
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
 f39ceb8 
  
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_case1.sql
 PRE-CREATION 
  
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_case2.sql
 PRE-CREATION 
  
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_case3.sql
 PRE-CREATION 
  
tajo-core/tajo-core-backend/src/test/resources/queries/TestCreateTable/quoted_ddl.sql
 PRE-CREATION 
  
tajo-core/tajo-core-backend/src/test/resources/results/TestCreateTable/quoted_case1.result
 PRE-CREATION 
  
tajo-core/tajo-core-backend/src/test/resources/results/TestCreateTable/quoted_case2.result
 PRE-CREATION 
  
tajo-core/tajo-core-backend/src/test/resources/results/TestCreateTable/quoted_case3.result
 PRE-CREATION 

Diff: https://reviews.apache.org/r/18678/diff/


Testing
-------

mvn clean install


Thanks,

Hyunsik Choi

Reply via email to