----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18729/#review36108 -----------------------------------------------------------
Ship it! +1 Nice finding!! It works correctly. - Jinho Kim On March 4, 2014, 6:40 a.m., hyoungjun kim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18729/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 6:40 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-646 > https://issues.apache.org/jira/browse/TAJO-646 > > > Repository: tajo > > > Description > ------- > > I tested Tajo JDBC Driver like bellow. After closing connection the TestCase > still running. > {code} > public static void main(String[] args) throws Exception { > Class.forName("org.apache.tajo.jdbc.TajoDriver").newInstance(); > Connection conn = DriverManager > .getConnection("jdbc:tajo://127.0.0.1:26002"); > > Statement stmt = null; > ResultSet rs = null; > try { > stmt = conn.createStatement(); > rs = stmt.executeQuery("select * from table1"); > while (rs.next()) { > System.out.println(rs.getString(1) + "," + > rs.getString(3)); > } > } finally { > if (rs != null) rs.close(); > if (stmt != null) stmt.close(); > if (conn != null) conn.close(); > } > } > {code} > > > Diffs > ----- > > > tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java > 1a7e54c67f1b81a949c9b5cb7c9514d713cee0bb > tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java > d9c511e6920032f819cdf61302f6d6108945349b > tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSet.java > 942107c9151797763758e97813f06e3a19d5c959 > tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java > b3afcdb2d9f3e6393e27e2657bc103e86733589d > tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java > 3f724e8c7cb98ee5eee5e99e0829feb7ecce809d > tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java > ba2b9193fe7a962127c5a45641225b1d557732d4 > > Diff: https://reviews.apache.org/r/18729/diff/ > > > Testing > ------- > > > Thanks, > > hyoungjun kim > >
