[
https://issues.apache.org/jira/browse/TAJO-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922128#comment-13922128
]
Tajo QA commented on TAJO-665:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12633014/TAJO-665.patch
against master revision 4089c9d.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:red}-1 tests included.{color} The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 184 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests.{color} The patch passed unit tests in
tajo-core/tajo-core-backend.
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/193//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/193//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/193//console
This message is automatically generated.
> sort buffer size must be dealt as long type values.
> ---------------------------------------------------
>
> Key: TAJO-665
> URL: https://issues.apache.org/jira/browse/TAJO-665
> Project: Tajo
> Issue Type: Improvement
> Reporter: Hyunsik Choi
> Assignee: hyoungjunkim
> Fix For: 0.8-incubating, 1.0-incubating
>
> Attachments: TAJO-665.patch
>
>
> sort buffer size (tajo.executor.external-sort.buffer-mb in TajoConf) is used
> to determine in-memory buffer for external merge sort. Currently, its type is
> integer. So, if users can set more than 2GB to sort buffer size, external
> merge operator will meet negative sort buffer size. Finally, it will cause
> significant performance degradation.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
