----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19392/#review38078 -----------------------------------------------------------
Ship it! +1 Thanks Jinho, and this issue was a necessary function to tajo. 'mvn clean install' and other unit tests finished successfully. Push it. :) - Jung JaeHwa On March 21, 2014, 9:16 a.m., Jinho Kim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19392/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 9:16 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-694 > https://issues.apache.org/jira/browse/TAJO-694 > > > Repository: tajo > > > Description > ------- > > Currently, tajo uses the Hadoop 2.2.0. but Hadoop 2.3.0 has been released. > We need to keep both 2.3.0 and 2.2.0 > * trunk default : 2.3.0 > * branch-0.8.0 default : 2.2.0 > > {code:title=Build with hadoop version} > mvn clean package -Pdist -Dhadoop.version=2.3.0 -DskipTests -Dtar > {code} > > > Diffs > ----- > > BUILDING.txt 8dcc179b684aa53d33053b42284490de3f494be2 > tajo-core/tajo-core-pullserver/pom.xml > 0bdfed202edcc60aa21fabbca8eb89ae8d74bff9 > > tajo-core/tajo-core-pullserver/src/main/hadoop-2.2.0/org/apache/tajo/pullserver/listener/FileCloseListener.java > PRE-CREATION > > tajo-core/tajo-core-pullserver/src/main/hadoop-2.3.0/org/apache/tajo/pullserver/listener/FileCloseListener.java > PRE-CREATION > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/FadvisedChunkedFile.java > ec34f0040dca4eefddfc88767e452a679b066292 > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/FadvisedFileRegion.java > 81e0bf1b5d7a1b7a8f8e5e6870bd1e23faf06224 > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java > 8054a40d2681dcbf7da428c7e950277964161bae > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java > a42763563d9be2b21870e7c6fbd1e5c02dd1960b > tajo-dist/src/main/bin/tajo 6b93203a4dcde465c5a3bc7e2a972eb54b7946fb > tajo-project/pom.xml 59628a954acc89bf98e8a623683ad40d1a630c9e > > Diff: https://reviews.apache.org/r/19392/diff/ > > > Testing > ------- > > mvn clean package -Pdist -Dhadoop.version=2.3.0 -Phcatalog-0.12.0 -DskipTests > -Dtar > mvn clean package -Pdist -Dhadoop.version=2.2.0 -Phcatalog-0.12.0 -DskipTests > -Dtar > > > Thanks, > > Jinho Kim > >
