----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19567/#review38275 -----------------------------------------------------------
tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java <https://reviews.apache.org/r/19567/#comment70324> Seems to "new String()" is not needed tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java <https://reviews.apache.org/r/19567/#comment70325> the encoder and decoder should be new instance. Here is example, RowStoreEncoder encoder = RowStoreEncoder.getInstance(schema); RowStoreEncoder encoder2 = RowStoreEncoder.getInstance(schema2); byte [] bytes = encoder.toBytes(tuple); - Jinho Kim On March 23, 2014, 1:22 p.m., Jihoon Son wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19567/ > ----------------------------------------------------------- > > (Updated March 23, 2014, 1:22 p.m.) > > > Review request for Tajo and Jinho Kim. > > > Repository: tajo > > > Description > ------- > > See the title. Since Null values are not handled, the > BufferUnderflowException occurs while data is read from ByteBuffer. > > To handle null values, I added the null flag. > Also, I added a test case, but it also tests TAJO-671. > I'm sorry for confusing you, but this would be better because the very > similar test code is used for both issues. > > > Diffs > ----- > > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java > 500001f > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java > 54c6f74 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/RangeRetrieverHandler.java > a54fa80 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java > 4839451 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java > 1975a57 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java > bba47cc > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/util/TestTupleUtil.java > c6ec236 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java > 65b7d1e > > tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2.tbl > f33b22c > > tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort2.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result > b5817f8 > > tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort2.result > PRE-CREATION > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java > 8054a40 > > tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java > a427635 > tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java > 7a421a8 > tajo-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java > bc8fe96 > > Diff: https://reviews.apache.org/r/19567/diff/ > > > Testing > ------- > > - mvn clean install > > - order by test on real data > > > Thanks, > > Jihoon Son > >
