[
https://issues.apache.org/jira/browse/TEZ-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096276#comment-14096276
]
Bikas Saha commented on TEZ-1072:
---------------------------------
+1 on just removing.
public abstract DAGStatus waitForCompletionWithStatusUpdates(@Nullable
Set<Vertex> vertices,
@Nullable Set<StatusGetOpts> statusGetOpts) throws IOException,
TezException;
And renaming
public abstract DAGStatus waitForCompletionWithAllStatusUpdates(FOO) to
public abstract DAGStatus waitForCompletionWithStatusUpdates(FOO)
[~jeagles] I see what you are saying with the Utils class but it seems more
natural to be able to use the DAGClient directly IMO.
> Consolidate monitoring APIs in DAGClient
> ----------------------------------------
>
> Key: TEZ-1072
> URL: https://issues.apache.org/jira/browse/TEZ-1072
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Priority: Blocker
> Labels: api
> Attachments: TEZ-1072-DAGCLIENTUTILS-v1.patch
>
>
> Rename waitForCompletionWithAllStatusUpdates - was this meant to be
> waitForCompletionWithAllVertexUpdates
> Reduce the number of methods exposed - waitForCompletion,
> waitForCompletionWithStatusUpdates(@Nullable Set<Vertex> vertices,
> @Nullable Set<StatusGetOpts> statusGetOpts),
> waitForCompletionWithAllStatusUpdates(@Nullable Set<StatusGetOpts>
> statusGetOpts)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
