[ https://issues.apache.org/jira/browse/TEZ-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111732#comment-14111732 ]
Rajesh Balamohan commented on TEZ-1503: --------------------------------------- If a custom processor gets different inputs (i.e unordered + ordered), should the custom processor check for the instance of Reader and cast it to KeyValueReader/KeyValuesReader? e.g getInputs().values().iterator().next().getReader() would return KeyValuesReader for orderedInput and KeyValueReader for unordered case. Had it been KeyValuesReader in UnorderedKVInput (even though we would fake it), user does not need to cast to relevant reader impls. > UnorderedKVInput.getReader() should return KeyValuesReader > ---------------------------------------------------------- > > Key: TEZ-1503 > URL: https://issues.apache.org/jira/browse/TEZ-1503 > Project: Apache Tez > Issue Type: Bug > Reporter: Rajesh Balamohan > > Currently OrderedGroupedKVInput.getReader() returns KeyValuesReader and > UnorderedKVInput.getReader() returns KeyValueReader. > It would be useful to return KeyValuesReader for UnorderedKVInput to be > consistent with OrderedGroupedKVInput. -- This message was sent by Atlassian JIRA (v6.2#6252)