[ 
https://issues.apache.org/jira/browse/TEZ-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114148#comment-14114148
 ] 

Bikas Saha commented on TEZ-1511:
---------------------------------

bq. The use of NEW_API_CONFIG seems incorrect. 
Not sure what you mean here. The field is different for the Input and the 
Output. The Input always has mapper and the Output always has reducer. The 
patch removes a bug in the Output where is was looking at mapper. The private 
constant prevents such bugs in the future.

I can change to use Configuration::getClassByName instead.

> MROutputConfigBuilder sets OutputFormat as String class if OutputFormat is 
> not provided
> ---------------------------------------------------------------------------------------
>
>                 Key: TEZ-1511
>                 URL: https://issues.apache.org/jira/browse/TEZ-1511
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Bikas Saha
>            Priority: Blocker
>         Attachments: TEZ-1511.1.patch, TEZ-1511.2.patch
>
>
> Code uses: 
> {code}
>           this.outputFormat = 
> ReflectionUtils.getClass(conf.get(MRJobConfig.OUTPUT_FORMAT_CLASS_ATTR));
>         } else {
>           this.outputFormat = 
> ReflectionUtils.getClass(conf.get("mapred.output.format.class"));
> {code}
> where ReflectionUtils has :
> {code}
> <T> Class<T> getClass(T o)
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to