[ 
https://issues.apache.org/jira/browse/TEZ-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187788#comment-14187788
 ] 

Jeff Zhang commented on TEZ-1701:
---------------------------------

[~hitesh] 

* Would the method getBatchEvents return events much better ?
Change it to:
{code}
List<DAGHistoryEvent> getEventBatch();
{code}

* Found some duplicated code with RecoveryService (about skippedDags), but we 
can do that in future. One place is difference from RecoveryService needs your 
confirm ( is it possible dagId is null ? )
RecoveryService:
{code}
if (dagId == null || skippedDAGs.contains(dagId)) {
{code}
ATSHistoryLoggingService
{code}
if (dagId != null && skippedDAGs.contains(dagId))
{code}

* And unit test case may not be enough for ATSHistoryLoggingService, but we can 
do it in another jira,since this is only for batch events. 

> ATS fixes to flush all history events and also using batching
> -------------------------------------------------------------
>
>                 Key: TEZ-1701
>                 URL: https://issues.apache.org/jira/browse/TEZ-1701
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: TEZ-1701.1.patch
>
>
> There are cases when the timeline server can get backlogged. To address this, 
> the AM should wait for a longer period to send events to it. Also, sending 
> events in batches will reduce the load. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to