[
https://issues.apache.org/jira/browse/TEZ-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188297#comment-14188297
]
Jeff Zhang commented on TEZ-1703:
---------------------------------
[~sseth] Thanks for your review and suggestion.
You are right, catch the exception in RootInputInitializerManager and send
VertexEventRootInputFailed would be much more simple and clean.
I attach a new patch, please help review.
bq. Does DAG have to change to add getAppContext() ?
Revert the change as we don't need it in the new patch.
> Exception handling for InputInitializer
> ---------------------------------------
>
> Key: TEZ-1703
> URL: https://issues.apache.org/jira/browse/TEZ-1703
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.5.1
> Reporter: Jeff Zhang
> Attachments: TEZ-1703-2.patch, TEZ-1703.patch
>
>
> For handleInputInitializerEvent - this should be fairly straightfoward to
> handle. At the moment this is an inline call from within the AsyncDispatcher,
> and will end up causing a RuntimeException. The RuntimeException can be
> changed to a AMUserCodeException which will take care of this.
> For onVertexStateUpdated, this eventually gets invoked from within
> RootInputInitializerManager. Catching exceptions there and sending a
> RootInputInitialzierFailedEvent should be enough to fix this ? May require
> some state machine changes to handle this event on a few more states.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
