[ 
https://issues.apache.org/jira/browse/TEZ-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204653#comment-14204653
 ] 

Prakash Ramachandran commented on TEZ-1757:
-------------------------------------------

- in App.ExTable.FilterBlock.content The column width is set in filterBlock, 
which is optional(hasFilter=false wont show it). doesn't adding the columns and 
redrawing the table do the same thing? also wont this break other functionality 
like fixed columns, forcefill, scrolling etc (not used now but is quite useful 
once many columns are there)?
- PaginatedContentMixin - This mixin was meant for fetching paginated data. 
IMHO the column selection ui and functionality does not belong here, and should 
be moved to another mixin.
- _createList in paginatedcontent.js is empty and unused.
- customize-component - too generic naming, does not convey what it does. cant 
it be replaced with a <i> and css class? something like <i 
class='column-selector-button' {{action yourfunction}}> ?

> Column selector for tables.
> ---------------------------
>
>                 Key: TEZ-1757
>                 URL: https://issues.apache.org/jira/browse/TEZ-1757
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Sreenath Somarajapuram
>            Assignee: Sreenath Somarajapuram
>         Attachments: TEZ-1757.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to