[ 
https://issues.apache.org/jira/browse/TEZ-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247214#comment-14247214
 ] 

Hitesh Shah commented on TEZ-1576:
----------------------------------

[~saurzcode] The patch cannot be accepted as is as it is indentation is 
incorrect with respect to the general guidelines for the project. Furthermore, 
in most cases, when fixing issues, you should restrict your changes to just the 
required ones without any additional whitespace changes. 

Also, for the actual issue itself, it might be better to remove "When using 
this mini cluster, the user is expected to" line itself. For the 
MiniTezCluster, there is no real need to specify the defaultFS.



> Class level comment in {{MiniTezCluster}} ends abruptly
> -------------------------------------------------------
>
>                 Key: TEZ-1576
>                 URL: https://issues.apache.org/jira/browse/TEZ-1576
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Ufuk Celebi
>            Assignee: Saurabh Chhajed
>            Priority: Trivial
>         Attachments: TEZ-1576.1.patch
>
>
> The class level comment in {{MiniTezCluster}} ends abruptly:
> {code}
> /**
>  * Configures and starts the Tez-specific components in the YARN cluster.
>  *
>  * When using this mini cluster, the user is expected to
>  */
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to