[ 
https://issues.apache.org/jira/browse/TEZ-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272209#comment-14272209
 ] 

Rajesh Balamohan commented on TEZ-1904:
---------------------------------------

lgtm. +1

very minor comment. 

IFile line 169: 
>>
this.valueClass = valueClass;
>>
This field is never read after TEZ-1274. Might need to remove this. If 
relevant, please add it before checkin.


> Fix findbugs warnings in tez-runtime-library
> --------------------------------------------
>
>                 Key: TEZ-1904
>                 URL: https://issues.apache.org/jira/browse/TEZ-1904
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Hitesh Shah
>            Assignee: Siddharth Seth
>         Attachments: TEZ-1904.1.txt, TEZ-1904.2.txt, TEZ-1904.3.txt
>
>
> https://builds.apache.org/job/PreCommit-Tez-Build/8/artifact/patchprocess/newPatchFindbugsWarningstez-runtime-library.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to