[ 
https://issues.apache.org/jira/browse/TEZ-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298349#comment-14298349
 ] 

Hadoop QA commented on TEZ-993:
-------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12695471/TEZ-993-4.patch
  against master revision a1c8518.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 4 
warning messages.
        See 
https://builds.apache.org/job/PreCommit-TEZ-Build/96//artifact/patchprocess/diffJavadocWarnings.txt
 for details.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 6 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/96//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TEZ-Build/96//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/96//console

This message is automatically generated.

> Remove application logic from RecoveryService
> ---------------------------------------------
>
>                 Key: TEZ-993
>                 URL: https://issues.apache.org/jira/browse/TEZ-993
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Jeff Zhang
>         Attachments: TEZ-993-3.patch, TEZ-993-4.patch, Tez-993-2.patch, 
> Tez-993.patch
>
>
> Currently RecoveryService storage logic knows a lot about the DAG like which 
> dag is pre-warm and does not need to be stored, which events needs special 
> treatment etc. This kind of logic couples the DAG and the storage more than 
> is probably necessary and can be a source of complications down the road. The 
> storage should ideally be simply storing a sequence of arbitrary records 
> delimited by a marker.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to