[ 
https://issues.apache.org/jira/browse/TEZ-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298442#comment-14298442
 ] 

Bikas Saha commented on TEZ-2011:
---------------------------------

The patch changes the InputReady manager to wait for CONFIGURED signal from all 
source vertices and its own vertex to start before taking any action. Thus any 
changes in parallelism in those vertices will take effect before its data 
structures are initialized and so the calculations will be correct. The logic 
is essentially the same as before but delayed till all configured signals are 
received.
Updated tests for different cases. [~rajesh.balamohan] Please review. Currently 
this is not an issue since the AM is essentially locked on the central 
dispatcher. But after TEZ-1914 this may be an issue.

> InputReadyVertexManager not resilient to updates in parallelism
> ---------------------------------------------------------------
>
>                 Key: TEZ-2011
>                 URL: https://issues.apache.org/jira/browse/TEZ-2011
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: TEZ-2011.1.patch
>
>
> It sets up its internal book-keeping upon onVertexStarted() but that 
> book-keeping can be wrong if its parallelism changes after that. It needs to 
> subscribe to Vertex configured event for its source vertices to make sure 
> that all changes have been made before initializing its internal state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to