[ 
https://issues.apache.org/jira/browse/TEZ-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377297#comment-14377297
 ] 

Hitesh Shah edited comment on TEZ-1909 at 3/24/15 5:07 AM:
-----------------------------------------------------------

Comments:

{code}
LOG.warn("Other recovery files will be skipped due to error in the previous 
recovery file");
{code}
  - please add the file name to this log line

For TEZ_AM_RECOVERY_HANDLE_REMAINING_EVENT_WHEN_STOPPED, maybe change to 
TEZ_TEST_... and likewise change property value. No scope defined? 

It seems like the patch for this jira has been merged with fixes for a 
different jira? Can these be separated out? 





was (Author: hitesh):
Comments:

{code}
LOG.warn("Other recovery files will be skipped due to error in the previous 
recovery file");
{code}
  - please add the file name to this line as well as its length 

For TEZ_AM_RECOVERY_HANDLE_REMAINING_EVENT_WHEN_STOPPED, maybe change to 
TEZ_TEST_... and likewise change property value. No scope defined? 

It seems like the patch for this jira has been merged with fixes for a 
different jira? Can these be separated out? 




> Remove need to copy over all events from attempt 1 to attempt 2 dir
> -------------------------------------------------------------------
>
>                 Key: TEZ-1909
>                 URL: https://issues.apache.org/jira/browse/TEZ-1909
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Hitesh Shah
>            Assignee: Jeff Zhang
>         Attachments: TEZ-1909-1.patch, TEZ-1909-2.patch, TEZ-1909-3.patch
>
>
> Use of file versions should prevent the need for copying over data into a 
> second attempt dir. Care needs to be taken to handle "last corrupt record" 
> handling. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to