[ 
https://issues.apache.org/jira/browse/TEZ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378996#comment-14378996
 ] 

Zhijie Shen commented on TEZ-2205:
----------------------------------

bq. i.e option 3's impl would be:

LGTM. For your reference, this is what we did in MR:

{code}
    if (conf.getBoolean(MRJobConfig.MAPREDUCE_JOB_EMIT_TIMELINE_DATA,
        MRJobConfig.DEFAULT_MAPREDUCE_JOB_EMIT_TIMELINE_DATA)) {
      if (conf.getBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED,
            YarnConfiguration.DEFAULT_TIMELINE_SERVICE_ENABLED)) {
        timelineClient = TimelineClient.createTimelineClient();
        timelineClient.init(conf);
        LOG.info("Timeline service is enabled");
        LOG.info("Emitting job history data to the timeline server is enabled");
      } else {
        LOG.info("Timeline service is not enabled");
      }
    } else {
      LOG.info("Emitting job history data to the timeline server is not 
enabled");
    }
{code}
And only when {{timelineClient != null}}, MR will publish the history info to 
the timeline server.

> Tez still tries to post to ATS when yarn.timeline-service.enabled=false
> -----------------------------------------------------------------------
>
>                 Key: TEZ-2205
>                 URL: https://issues.apache.org/jira/browse/TEZ-2205
>             Project: Apache Tez
>          Issue Type: Sub-task
>    Affects Versions: 0.6.1
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: TEZ-2205.wip.patch
>
>
> when set yarn.timeline-service.enabled=false, Tez still tries posting to ATS, 
> but hits error as token is not found. Does not fail the job because of the 
> fix to not fail job when there is error posting to ATS. But it should not be 
> trying to post to ATS in the first place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to