[
https://issues.apache.org/jira/browse/TEZ-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Zhang updated TEZ-2224:
----------------------------
Comment: was deleted
(was: bq. Is there a reason why we want to prevent new events from being
processed on a shutdown?
No special reason for that, just borrow the code from AsynDispatcher. But I
think you are right, AsyncDispatcher is for general use case, here for
RecoveringService, we need to handle events even when it is stopped.
bq. TEZ_AM_RECOVERY_HANDLE_REMAINING_EVENT_WHEN_STOPPED_DEFAULT being false by
default is probably wrong. For a real-world scenario, as many pending events
that are seen and can be processed, should be processed.
When there's no this flag, by default we won't process any pending events, is
there any consideration at that time ? (not sure, maybe for performance
consideration, like in non-session mode that dag is finished while recovery
events handling is not completed but is not necessary) I try to be conservative
to make the behavior as same as before. )
> EventQueue empty doesn't mean events are consumed in RecoveryService
> --------------------------------------------------------------------
>
> Key: TEZ-2224
> URL: https://issues.apache.org/jira/browse/TEZ-2224
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-2224-1.patch, TEZ-2224-2.patch
>
>
> If the event queue is empty, the event may still been processing. Should fix
> it like AsyncDispatcher
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
