[ https://issues.apache.org/jira/browse/TEZ-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518581#comment-14518581 ]
TezQA commented on TEZ-2256: ---------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723914/remove-btse-1-MASTER.patch against master revision 5b2f011. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/569//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/569//console This message is automatically generated. > Avoid use of BufferTooSmallException to signal end of buffer in > UnorderedPartitionedKVWriter > -------------------------------------------------------------------------------------------- > > Key: TEZ-2256 > URL: https://issues.apache.org/jira/browse/TEZ-2256 > Project: Apache Tez > Issue Type: Improvement > Affects Versions: 0.6.0, 0.7.0 > Reporter: Cyrille Chépélov > Assignee: Cyrille Chépélov > Priority: Critical > Labels: patch > Attachments: remove-btse-1-MASTER.patch, remove-btse-1-rfc.patch > > Original Estimate: 6h > Remaining Estimate: 6h > > UnorderedPartitionedKVWriter delegates serialization to the application, > passing it a private ByteArrayOutputStream. In case the buffer is exhausted, > ByteArrayOutputStream signals that with a private BufferTooSmallException, > which can be seen but not dealt with by the application. As [~cwensel] > pointed out, when the application is in fact a complex framework, there is no > way to distinguish this exception from a real failure, which compels logging > the full stack even for reasonable events such as "buffer complete". > Suggested approach: set a "complete" flag in ByteArrayOutputStream that > disables any further output, and replace BufferTooSmallException (BTSE) > handling by checking that flag. > [~sseth] suggested checking out SortedOutput as well, as the mechanisms there > should be similar. > I'll give this a go this week. -- This message was sent by Atlassian JIRA (v6.3.4#6332)