[ 
https://issues.apache.org/jira/browse/TEZ-2369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527884#comment-14527884
 ] 

Hitesh Shah commented on TEZ-2369:
----------------------------------

The patch does not include the "Integer successfulAttempt = 
vertexSuccessfulAttemptMap.get(taskId.getId());" change. Maybe that should be 
added back as it seems a safe enough change that can be backported to older 
branches.

+1 for the unit test change.  

> Add a few unit tests for RootInputInitializerManager
> ----------------------------------------------------
>
>                 Key: TEZ-2369
>                 URL: https://issues.apache.org/jira/browse/TEZ-2369
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-2369.1.txt, TEZ-2369.2.txt
>
>
> {code}
> -      Integer successfulAttempt = vertexSuccessfulAttemptMap.get(taskId);
> +      Integer successfulAttempt = 
> vertexSuccessfulAttemptMap.get(taskId.getId());
> {code}
> This could cause events to be sent multiple times.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to