[ https://issues.apache.org/jira/browse/TEZ-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576568#comment-14576568 ]
TezQA commented on TEZ-2244: ---------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12738288/TEZ-2244.4.patch against master revision 333edd0. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 3.0.1) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/803//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/803//console This message is automatically generated. > PipelinedSorter: Progressive allocation for sort-buffers > -------------------------------------------------------- > > Key: TEZ-2244 > URL: https://issues.apache.org/jira/browse/TEZ-2244 > Project: Apache Tez > Issue Type: Improvement > Affects Versions: 0.7.0 > Reporter: Gopal V > Assignee: Rajesh Balamohan > Attachments: TEZ-2244.1.patch, TEZ-2244.2.patch, TEZ-2244.3.patch, > TEZ-2244.4.patch, TEZ-2244.WIP.patch > > > Currently, the sort buffers are allocated pessimistically for all tasks so > that the largest task's spill stays within memory. > After the chained buffer implementation inside PipelinedSorter, it brings up > the possibility of only allocating the first chunk of the sort buffer when > the sorter starts up. > This allows for the tasks which do not heavily use the sort buffer (like a > grouping aggregation) to use the sort-space only when the map-aggregation > turns itself off. > Not reserving memory on startup hurts the worst-case scenario for the > pipelined sorter, but improves the average case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)