[ https://issues.apache.org/jira/browse/TEZ-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606615#comment-14606615 ]
Jeff Zhang edited comment on TEZ-2579 at 6/29/15 11:17 PM: ----------------------------------------------------------- bq. because that may end up killing the successful attempt. But the successful attempt should also be finished, right ? It is supposed not to be killed. {code} for (TaskAttempt attempt : task.attempts.values()) { if (attempt.getID() != task.successfulAttempt && !attempt.isFinished()) { // but it won't affect the state machine transition, because the successful task attempt should already complete. {code} was (Author: zjffdu): But the successful attempt should also be finished, right ? {code} for (TaskAttempt attempt : task.attempts.values()) { if (attempt.getID() != task.successfulAttempt && !attempt.isFinished()) { // but it won't affect the state machine transition, because the successful task attempt should already complete. {code} > Incorrect comparison of TaskAttemptId > ------------------------------------- > > Key: TEZ-2579 > URL: https://issues.apache.org/jira/browse/TEZ-2579 > Project: Apache Tez > Issue Type: Bug > Reporter: Jeff Zhang > Assignee: Jeff Zhang > Attachments: TEZ-2579-1.patch > > > TaskImpl#AttemptSucceededTransition > {code} > // issue kill to all other attempts > for (TaskAttempt attempt : task.attempts.values()) { > if (attempt.getID() != task.successfulAttempt && // should use > !equals > !attempt.isFinished()) { // but it won't affect the state > machine transition, because the successful task attempt should already > complete. > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)