[ https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615907#comment-14615907 ]
TezQA commented on TEZ-2591: ---------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12743817/TEZ-2591.2.patch against master revision cb59851. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 3.0.1) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in : org.apache.tez.dag.library.vertexmanager.TestShuffleVertexManager Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/885//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/885//console This message is automatically generated. > Remove unneeded methods from EdgeManagerPludinOnDemand > ------------------------------------------------------ > > Key: TEZ-2591 > URL: https://issues.apache.org/jira/browse/TEZ-2591 > Project: Apache Tez > Issue Type: Bug > Reporter: Bikas Saha > Assignee: Bikas Saha > Attachments: TEZ-2591.1.patch, TEZ-2591.2.patch > > > EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some > common methods. Removing this dependency would be cleaner for the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)