[
https://issues.apache.org/jira/browse/TEZ-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617948#comment-14617948
]
TezQA commented on TEZ-2604:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12744119/TEZ-2604.001.patch
against master revision cb59851.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/889//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/889//console
This message is automatically generated.
> PipelinedSorter doesn't use number of items when creating SortSpan
> -------------------------------------------------------------------
>
> Key: TEZ-2604
> URL: https://issues.apache.org/jira/browse/TEZ-2604
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Tsuyoshi Ozawa
> Assignee: Tsuyoshi Ozawa
> Attachments: TEZ-2604.001.patch
>
>
> {quote}
> int items = 1024*1024;
> int perItem = 16;
> if(span.length() != 0) {
> items = span.length();
> perItem = span.kvbuffer.limit()/items;
> items = (int) ((span.capacity)/(METASIZE+perItem));
> if(items > 1024*1024) {
> // our goal is to have 1M splits and sort early
> items = 1024*1024;
> }
> }
> Preconditions.checkArgument(listIterator.hasNext(), "block iterator
> should not be empty");
> span = new SortSpan((ByteBuffer)listIterator.next().clear(),
> (1024*1024),
> perItem, ConfigUtils.getIntermediateOutputKeyComparator(this.conf));
> {quote}
> Should we use items instead of (1024*1024)?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
