[
https://issues.apache.org/jira/browse/TEZ-2808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739942#comment-14739942
]
TezQA commented on TEZ-2808:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12755241/TEZ-2808.1.patch
against master revision cb0890d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1107//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1107//console
This message is automatically generated.
> Race condition between preemption and container assignment
> ----------------------------------------------------------
>
> Key: TEZ-2808
> URL: https://issues.apache.org/jira/browse/TEZ-2808
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2808.1.patch
>
>
> New container allocated. Put in delayed container manager queue. Triggers
> assignment run on delayed container manager thread.
> On AMRMClient thread callback, preemption is called. This is to ensure
> preemption logic is guaranteed to be invoked at regular intervals even though
> nothing else may be happening because there are no containers
> allocated/to-match. Preemption logic checks if containers are available to
> assign by looking at delayed container manager queue. If by this time, the
> assignment thread has polled the queue to remove the container for assignment
> checking, then the preemption code will see no containers available to
> assign. So it proceeds to preempt containers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
