[
https://issues.apache.org/jira/browse/TEZ-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740434#comment-14740434
]
Rajesh Balamohan commented on TEZ-2810:
---------------------------------------
Minor comments
- VertexInfo.getTaskAttemptsInternal can possibly be optimized not to have too
many lists created. Not related to this change, I will create a separate JIRA
for it.
- The following condition in CriticalPathAnalyzer match multiple preempted
attempts. Depending on the number of attempts that are getting pre-empted and
size of the job, notes section can become quite big?
{noformat}
if (a.getFinishTime() > creationTime && a.getFinishTime() < allocationTime){
{noformat}
Should the first pre-empted attempt name be mentioned & provide additional info
on the number of pre-empted attempts within that time range of creationTime &
allocationTime?
lgtm. +1
> Support for showing allocation delays due to internal preemption
> ----------------------------------------------------------------
>
> Key: TEZ-2810
> URL: https://issues.apache.org/jira/browse/TEZ-2810
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2810.1.patch, cp4-preempt-1.png, cp4-preempt-2.png,
> cp4-preempt-3.png, cp5-no-launch.png
>
>
> Also adds support for drawing critical path for attempts that did not get
> allocated or launched.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
