[ 
https://issues.apache.org/jira/browse/TEZ-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936160#comment-14936160
 ] 

Jeff Zhang commented on TEZ-2855:
---------------------------------

Comments:
* Should we put the VertexManager initialization code at the end of vertex 
initialization ? Because due to the code change of this patch, vertex may 
handle VMEvent when it is still uninitialized. That means 
VM#onVertexManagerEvent may not behave correctly as some info of the 
VertexManagerContext may not set correctly yet (such as numTasks)
* TestVertexImpl, it is not necessary to send init to V3 explicitly. V3's init 
should be triggered by the init of V1 & V2
{code}
    dispatcher.getEventHandler().handle(new VertexEvent(v3.getVertexId(),
        VertexEventType.V_INIT));          // remove this
{code}

> NPE while routing events
> ------------------------
>
>                 Key: TEZ-2855
>                 URL: https://issues.apache.org/jira/browse/TEZ-2855
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>            Priority: Critical
>         Attachments: 2855log.gz, TEZ-2855.1.txt
>
>
> Observed while running against 0.8.0-alpha. This will likely affect 0.7 as 
> well - that'll be known after debugging.
> {code}
> 2015-09-24T12:13:42,675 ERROR [Dispatcher thread: Central] 
> common.AsyncDispatcher: Error in dispatcher thread
> java.lang.NullPointerException
>   at 
> org.apache.tez.dag.app.dag.impl.VertexImpl.handleRoutedTezEvents(VertexImpl.java:4429)
>  ~[TezAppJar.jar:0.8.0-alpha]
>   at 
> org.apache.tez.dag.app.dag.impl.VertexImpl.access$4000(VertexImpl.java:203) 
> ~[TezAppJar.jar:0.8.0-alpha]
>   at 
> org.apache.tez.dag.app.dag.impl.VertexImpl$RouteEventTransition.transition(VertexImpl.java:4175)
>  ~[TezAppJar.jar:0.8.0-alpha]
>   at 
> org.apache.tez.dag.app.dag.impl.VertexImpl$RouteEventTransition.transition(VertexImpl.java:4167)
>  ~[TezAppJar.jar:0.8.0-alpha]
>   at 
> org.apache.hadoop.yarn.state.StateMachineFactory$MultipleInternalArc.doTransition(StateMachineFactory.java:385)
>  ~[hadoop-yarn-common-2.6.0.jar:?]
>   at 
> org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302)
>  ~[hadoop-yarn-common-2.6.0.jar:?]
>   at 
> org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46)
>  ~[hadoop-yarn-common-2.6.0.jar:?]
>   at 
> org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448)
>  ~[hadoop-yarn-common-2.6.0.jar:?]
>   at 
> org.apache.tez.state.StateMachineTez.doTransition(StateMachineTez.java:57) 
> ~[TezAppJar.jar:0.8.0-alpha]
>   at org.apache.tez.dag.app.dag.impl.VertexImpl.handle(VertexImpl.java:1906) 
> ~[TezAppJar.jar:0.8.0-alpha]
>   at org.apache.tez.dag.app.dag.impl.VertexImpl.handle(VertexImpl.java:202) 
> ~[TezAppJar.jar:0.8.0-alpha]
>   at 
> org.apache.tez.dag.app.DAGAppMaster$VertexEventDispatcher.handle(DAGAppMaster.java:2069)
>  ~[TezAppJar.jar:0.8.0-alpha]
>   at 
> org.apache.tez.dag.app.DAGAppMaster$VertexEventDispatcher.handle(DAGAppMaster.java:2055)
>  ~[TezAppJar.jar:0.8.0-alpha]
>   at org.apache.tez.common.AsyncDispatcher.dispatch(AsyncDispatcher.java:183) 
> [tez-common-0.8.0-alpha.jar:0.8.0-alpha]
>   at org.apache.tez.common.AsyncDispatcher$1.run(AsyncDispatcher.java:114) 
> [tez-common-0.8.0-alpha.jar:0.8.0-alpha]
>   at java.lang.Thread.run(Thread.java:745) [?:1.8.0_40]
> 2015-09-24T12:13:42,681 INFO [HistoryEventHandlingThread] 
> impl.SimpleHistoryLoggingService: Writing event TASK_ATTEMPT_FINISHED to 
> history file
> {code}
> Looks like the VertexManager was null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to