[ 
https://issues.apache.org/jira/browse/TEZ-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093369#comment-15093369
 ] 

Bikas Saha commented on TEZ-2669:
---------------------------------

The choice of not having Exception in the API's but then wrapping all plugins 
inside wrapper classes to add an exception to the effective internal signature 
seems incongruous. Simply having the Exception in the signature makes things 
clear and informs implementations that its ok to throw an exception and notify 
the framework vs forcing them to swallow any-and-all exceptions because the 
method signature does not allow throwing exceptions.
However, if other reviewers are ok with this choice then I am fine with it.

Could you please remind me why TaskCommunicator.java is inside tez-dag instead 
of inside tez-api/serviceplugins like the rest of the plugins? And how does 
Hive/LLAP end up implementing it in that state?


> Propagation of errors from plugins to the AM for error reporting
> ----------------------------------------------------------------
>
>                 Key: TEZ-2669
>                 URL: https://issues.apache.org/jira/browse/TEZ-2669
>             Project: Apache Tez
>          Issue Type: Sub-task
>    Affects Versions: 0.8.0-alpha
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>            Priority: Blocker
>         Attachments: TEZ-2669.1.txt, TEZ-2669.2.txt, TEZ-2669.3.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to