[ https://issues.apache.org/jira/browse/TEZ-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171203#comment-15171203 ]
Hitesh Shah commented on TEZ-2988: ---------------------------------- Generally looks fine. Minor nit: Instead of putting the full block of code into the if section, maybe do a return if sessionStopped.compareAndSet(false, true) returns false with a comment on why the return is being done? > DAGAppMaster::shutdownTezAM should return with a no-op if it has been invoked > earlier > ------------------------------------------------------------------------------------- > > Key: TEZ-2988 > URL: https://issues.apache.org/jira/browse/TEZ-2988 > Project: Apache Tez > Issue Type: Bug > Reporter: Hitesh Shah > Assignee: Tsuyoshi Ozawa > Attachments: TEZ-2988.001.patch > > > If the session is already shutting down, DAGAppMaster::shutdownTezAM() should > not block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)