[
https://issues.apache.org/jira/browse/TEZ-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398395#comment-15398395
]
Hitesh Shah edited comment on TEZ-3384 at 7/28/16 11:17 PM:
------------------------------------------------------------
Comments:
- the unit test fails to run with patch 2.
{code}
assertEquals(dagId1.getGroupId(numDagsPerGroup),
dagId2.getGroupId(numDagsPerGroup),dagId3.getGroupId(numDagsPerGroup));
{code}
- the above seems wrong. Shouldnt there be 2 assert checks to ensure that
dag2 and dag3 do not belong to the same group?
was (Author: hitesh):
Comments:
- the unit test fails to run with patch 2.
{code]
assertEquals(dagId1.getGroupId(numDagsPerGroup),
dagId2.getGroupId(numDagsPerGroup),dagId3.getGroupId(numDagsPerGroup));
{code}
- the above seems wrong. Shouldnt there be 2 assert checks to ensure that
dag2 and dag3 do not belong to the same group?
> Fix testDAGGroupingGroupingEnabled unit test
> ---------------------------------------------
>
> Key: TEZ-3384
> URL: https://issues.apache.org/jira/browse/TEZ-3384
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Sushmitha Sreenivasan
> Assignee: Sushmitha Sreenivasan
> Attachments: TEZ-3384.1.patch, TEZ-3384.2.patch
>
>
> testDAGGroupingGroupingEnabled fails with the below stacktrace:
> Running org.apache.tez.dag.history.logging.ats.TestATSV15HistoryLoggingService
> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.673 sec <<<
> FAILURE!
> testDAGGroupingGroupingEnabled(org.apache.tez.dag.history.logging.ats.TestATSV15HistoryLoggingService)
> Time elapsed: 1.741 sec <<< FAILURE!
> java.lang.AssertionError: Values should be different. Actual:
> daggroup_1000_0001_0
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failEquals(Assert.java:185)
> at org.junit.Assert.assertNotEquals(Assert.java:161)
> at org.junit.Assert.assertNotEquals(Assert.java:175)
> at
> org.apache.tez.dag.history.logging.ats.TestATSV15HistoryLoggingService.testDAGGroupingGroupingEnabled(TestATSV15HistoryLoggingService.java:145)
> cc: [~harishjp] Can you please review? Thanks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
