[
https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413956#comment-15413956
]
Ming Ma commented on TEZ-3230:
------------------------------
Couple suggestions w.r.t. EdgeManager:
* {{CartesianProductEdgeManagerUnpartitioned#getNumDestinationConsumerTasks}}
doesn't depend on sourceTaskIndex. So it could cache the value in
initialization. Granted this isn' important given it is called only in the case
of INPUT_READ_ERROR_EVENT.
*
{{CartesianProductEdgeManagerPartitioned#routeCompositeDataMovementEventToDestination}}
optimization. Instead of computing the partition from taskTaskId, we can store
the destinationTaskIndex -> partition mapping. Then taskIdMapping becomes
unnecessary.
*
{{CartesianProductEdgeManagerPartitioned#routeInputSourceTaskFailedEventToDestination}}
computes the partition and use it to create EventRouteMetadata. It appears it
isn't necessary to specify the sourceTaskOutputIndex; Edge doesn't use that.
> Implement vertex manager and edge manager of cartesian product edge
> -------------------------------------------------------------------
>
> Key: TEZ-3230
> URL: https://issues.apache.org/jira/browse/TEZ-3230
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Zhiyuan Yang
> Assignee: Zhiyuan Yang
> Attachments: TEZ-3230.1.patch, TEZ-3230.2.patch, TEZ-3230.3.patch,
> TEZ-3230.WIP.1.patch, TEZ-3230.WIP.2.patch, TEZ-3230.WIP.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
