[
https://issues.apache.org/jira/browse/TEZ-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623698#comment-15623698
]
Ming Ma commented on TEZ-3465:
------------------------------
[~aplusplus] sorry for the delay. The patch looks good overall.
* Why does it track configured state for CP different from running state for
broadcast?
* Maybe update CartesianProduct sample to include the broadcast option.
* Nit: numCPSrcNotInConfigureState -> numCPSrcNotInConfiguredState.
> Support broadcast edge into cartesian product vertex and forbid other edges
> ---------------------------------------------------------------------------
>
> Key: TEZ-3465
> URL: https://issues.apache.org/jira/browse/TEZ-3465
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Zhiyuan Yang
> Assignee: Zhiyuan Yang
> Attachments: TEZ-3465.1.patch, TEZ-3465.2.patch, TEZ-3465.3.patch
>
>
> Cartesian product vertex manager should support other incoming edge type.
> Currently only broadcast edge is necessary, although potentially more edge
> types could also be. Custom edge need its own vertex manager which can't work
> with Cartesian product VM, so it has to be forbade.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
