[jira] [Commented] (TEZ-3616) TestMergeManager#testLocalDiskMergeMultipleTasks fails intermittently

[Harish Jaiprakash (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TEZ-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943456#comment-15943456
 ] 

Harish Jaiprakash commented on TEZ-3616:
----------------------------------------

Thanks [~ferhui], good catch on closeOnDiskFile not being mocked. We can remove 
the Answer mock and override closeOnDisk.
{code}
MergeManager t0mergeManagerReal =
  new MergeManager(conf, localFs, localDirAllocator, t0inputContext, null, 
null, null, null,
      t0exceptionReporter, 2000000, null, false, -1) {
          @Override
          public void closeOnDiskFile(FileChunk fc) {
             if (interruptInMiddle) { wait/sleep ... }
             super.closeOnDiskFile();
          }
  };
{code}

> TestMergeManager#testLocalDiskMergeMultipleTasks fails intermittently 
> ----------------------------------------------------------------------
>
>                 Key: TEZ-3616
>                 URL: https://issues.apache.org/jira/browse/TEZ-3616
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>         Environment: Ubuntu 14.04 
>            Reporter: Sonia Garudi
>            Assignee: Fei Hui
>              Labels: ppc64le, x86
>         Attachments: TEZ-3616.001.patch, TEZ-3616.002.patch
>
>
> In tez-runtime-library project, the 
> TestMergeManager#testLocalDiskMergeMultipleTasks test fails intermittently 
> with the following error:
> testLocalDiskMergeMultipleTasks(org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager)
>   Time elapsed: 1.395 sec  <<< FAILURE!
> java.lang.AssertionError: Values should be different. Actual: 1
>         at org.junit.Assert.fail(Assert.java:88)
>         at org.junit.Assert.failEquals(Assert.java:185)
>         at org.junit.Assert.assertNotEquals(Assert.java:161)
>         at org.junit.Assert.assertNotEquals(Assert.java:198)
>         at org.junit.Assert.assertNotEquals(Assert.java:209)
>         at 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager.testLocalDiskMergeMultipleTasks(TestMergeManager.java:878)
>         at 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager.testLocalDiskMergeMultipleTasks(TestMergeManager.java:628)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)