[ 
https://issues.apache.org/jira/browse/TEZ-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007120#comment-16007120
 ] 

Jonathan Eagles commented on TEZ-3719:
--------------------------------------

[~gopalv], everything checks out. One minor thing could be changing 
TasksImpl#getProgress

{code}
      final TaskState state = getState();
{code}

How do you feel about switching this to getInternalState? This will save us 
from remapping the internal states to the external state. Otherwise, I think 
this is ready to go.

> DAGImpl.computeProgress slows down dispatcher and ipc threads
> -------------------------------------------------------------
>
>                 Key: TEZ-3719
>                 URL: https://issues.apache.org/jira/browse/TEZ-3719
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Rajesh Balamohan
>            Assignee: Gopal V
>         Attachments: dispatcher_holding_lock.png, TEZ-3719.1.patch, 
> TEZ-3719.2.patch, TEZ-3719.wip.patch, tez_computeProgress_waiting_for_lock.png
>
>
> The Vertex readLock is held while computing progress, which prevents 
> scheduling of tasks from happening on that vertex (which needs a writeLock).
> Making the locked section do as little work as possible would speedup the AM.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to