[ https://issues.apache.org/jira/browse/TEZ-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008385#comment-16008385 ]
TezQA commented on TEZ-3723: ---------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12867790/TEZ-3723.002.patch against master revision de21f99. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 3.0.1) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in : org.apache.tez.runtime.library.common.shuffle.TestShuffleUtils org.apache.tez.runtime.library.common.writers.TestUnorderedPartitionedKVWriter Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2436//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2436//console This message is automatically generated. > TezIndexRecord#hasData() returns true for empty index record in the Unordered > case > ---------------------------------------------------------------------------------- > > Key: TEZ-3723 > URL: https://issues.apache.org/jira/browse/TEZ-3723 > Project: Apache Tez > Issue Type: Bug > Reporter: Kuhu Shukla > Assignee: Kuhu Shukla > Attachments: TEZ-3723.001.patch, TEZ-3723.002.patch > > > In the case of Unordered writer, use of {{hasData()}} returns true for empty > partitions since the rawlength is zero (as writer skips writing them out > altogether) and the check in hasData will fail as {{rawlength == > header.length +2}} fails. > This currently works for the ordered case(and the method is used here unlike > in unordered writer) but after TEZ-3605, it will fail for both scenarios. > Even if we don't use the method, the logic should be fixed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)