[ 
https://issues.apache.org/jira/browse/TEZ-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065331#comment-16065331
 ] 

Siddharth Seth commented on TEZ-3274:
-------------------------------------

Line 173: log should include the value for the source vertex instead of 0 (can 
be negative as well)
I don't think the dependency on hadoop-mapreduce-client-core is requried in 
tez-dag. (If it is required, the VM would need to move to to 
tez-runtime-library module)

Otherwise looks good to me, after addressing [~jeagles] comments.



> Vertex with MRInput and broadcast input does not respect slow start
> -------------------------------------------------------------------
>
>                 Key: TEZ-3274
>                 URL: https://issues.apache.org/jira/browse/TEZ-3274
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jonathan Eagles
>            Assignee: Eric Badger
>         Attachments: TEZ-3274.001.patch, TEZ-3274.002.patch, 
> TEZ-3274.003.patch, TEZ-3274.004.patch, TEZ-3274.005.patch
>
>
> Vertices with shuffle input and MRInput choose RootInputVertexManager (and 
> not ShuffleVertexManager) and start containers and tasks immediately. In this 
> scenario, resources can be wasted since they do not respect 
> tez.shuffle-vertex-manager.min-src-fraction 
> tez.shuffle-vertex-manager.max-src-fraction. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to